266ae8912a
Formatting in _draw_heater_status
8 years ago
6b9ca16f36
Patch lcd_print edge limit code
8 years ago
74d6dee920
User Command (Script) Menu
...
The menu (commands / scripts) is configurable in `Configuration_adv.h`.
- Added conditionals.
- Changed script handling.
- Slimmed and working!
- Added Status message.
- Returning to lcd status screen now!
- Example Configs Updated.
- Cleanups by @thinkyhead
8 years ago
d9c8072037
Edit PROPORTIONAL_FONT_RATIO comment
8 years ago
46b32e4548
Cleanup LCD interface, add lcd_reset_status
8 years ago
ca99d67ede
Fix UBL "Info screen" menu items
8 years ago
2c7a39bc0e
Fix LCD print aborted message
8 years ago
0f1e8c195d
Draw on LCD after value has changed
8 years ago
51587c4b43
Rename Feedrate to Velocity to match prior naming
8 years ago
9677f3f2f5
Patch up LCD Bed Leveling menu
8 years ago
fc2eaab7f3
Show home option in level bed menu
8 years ago
c6a7adc293
Patch G29 A and Q arguments to bypass setup
8 years ago
4cece2d72e
Use NAN for G29 W omitted parameters
8 years ago
2d71569138
Fix spacing in JSON output
8 years ago
b2d3c8aedd
Have G28 do a refresh of the display
8 years ago
50ab9c2e04
General cleanup of spacing, comments
8 years ago
f1e33afda4
Return to Bed Leveling menu when done
8 years ago
78d8c598e1
Fix lcd_synchronize with message
8 years ago
eb39d6e3e2
Don't draw progress bar until it has 1%
8 years ago
194f8b2f55
Start at Z=0 in manual probing
8 years ago
6f89db11f0
Allow lcd_setstatusPGM to reset the alert level
8 years ago
3fe333143c
Case light as a toggle menu item
8 years ago
d013bddfa8
Merge pull request #6876 from thinkyhead/bf_extend_leveling_menu
...
Extend the ABL/MBL Bed Leveling menu
8 years ago
01e7e234c6
Add more options to the Bed Leveling menu
8 years ago
0cbe448edf
Split up Control > Motion submenu
8 years ago
a3645ec921
Reference op with variable name
8 years ago
71367fd518
Scrolling status message option
8 years ago
b0eae68f57
Prevent bed temperature being set too high
8 years ago
493f0b0c62
Fix some compiler warnings
8 years ago
f379a326cc
enable DEACTIVATE_SERVOS_AFTER_MOVE with switching nozzle
...
When using switching nozzle it should be possible to disable the servo after move. Do it only if you do not need the servo power to keep the position.
8 years ago
33279a1e02
Code style tweak to gcode.h
8 years ago
ac959b12ee
Updates to language_es.h based on latest updates. ( #6871 )
...
Spanish language updates
8 years ago
55c700d537
Tweak to gcode.h
8 years ago
868e7db4ae
value check was looking at the code
8 years ago
fb5e0ffe16
Unify M600 and M125 pause features ( #6407 )
...
* Unify M600 and M125 pause features
* Cleanup per thinkyhead's comments
* Rename filament_change_menu_response to advanced_pause_menu_response
* Include HAS_BED_PROBE in QUIET_PROBING
* Update gMax example file
* is_idle() is out of scope without the braces
* Convert FT-i3-2020 to Advance Pause names...
* Allow pause even if not printing
8 years ago
b3a97b5013
Patch up LCD level bed menus
8 years ago
78af2b1444
Fix PROBE_MANUALLY via G-code
8 years ago
082da23391
One fewer EOL in M503 output
8 years ago
b15e531464
Fix screen change on character display
8 years ago
44e657766e
Add incompatibility error to Sanity Check for MIXING_EXTRUDER and LIN_ADVANCE
8 years ago
735405b2a4
Merge pull request #6848 from thinkyhead/bf_scara_M665
...
Add M665 for SCARA
8 years ago
ffa901f373
Merge pull request #6839 from thinkyhead/bf_day_ending_in_y
...
UBL ultralcd.cpp patches
8 years ago
361cbba113
Use M665 to set SCARA angle offsets
8 years ago
5ed63a5724
Apply const in prepare_kinematic_move_to
8 years ago
5cbe0244c5
Fixes for spindle/laser and SCARA probe bounds
8 years ago
1f52c9f5df
Neater Megatronics 3 pins
8 years ago
af81cb4cbb
Patch for M503 output
8 years ago
1d167a6874
Some cleanup, fixes for ultralcd.cpp UBL code
...
- Free up 30 bytes of SRAM in UBL LCD code
- Fix BUILD_ABS_MESH temperature
- Fix UBL indentation in ultralcd.cpp
- UBL vars lowercase, "convert to positive" sensibly
8 years ago
f4028fe088
New GCode Parser - Implementation
8 years ago
002a06c507
New GCode Parser - Configuration
8 years ago
ad915b667e
One more mesh_index_to_npos update
...
Followup to #6827
8 years ago
2881f0a48d
Fix, extend G42 with P (probe) parameter
...
- Also fix handling of SCARA and misuse of `codenum`.
8 years ago
d252d1b6a2
Merge pull request #6831 from thinkyhead/bf_move_g7
...
Move G7 to G42
8 years ago
82ca6248e2
Move G7 to G42
...
See: #6777
8 years ago
26ffa558a3
Use redraw flag for both types of LCD
8 years ago
3ff7515527
Merge pull request #6817 from cbusillo/patch-1
...
missing enable for M605 for duplication mode
8 years ago
34cfbc90cd
Use new attribute macros in more places
8 years ago
85b967657e
Embed G26/G29 in ubl class, with enhancements
8 years ago
c99bd69889
Apply const float & more
8 years ago
ad5638f78c
Cleanup some fastio code
8 years ago
e271521c39
Single user_canceled function in G26
8 years ago
c2ea22da49
Clean up whitespace
8 years ago
ceb62fc7e1
Fixes #6828 : M428 bug
8 years ago
48f7652143
UBL G29 -P3.1 smart fill ( #6823 )
...
* UBL G29 -P3.1 mesh fill with distance-weighted least squares fit.
* Back to original -O0 on G29 for now.
8 years ago
850203fb3a
Merge pull request #6816 from thinkyhead/bf_lcd_live_editing
...
Constrain LCD status message rendering
8 years ago
3129260c44
Misc. Clean Up ( #6822 )
...
* Misc. Clean Up
Mostly UBL related clean up.
- But fixed a bug in the thermistortables.
- Made G26 more responsive to user aborts.
- Added sanity checks for older name for UBL_MESH_VALIDATION.
- Made G29 P4 able to edit invalidated mesh points
- Restore a reasonable Fade Height for UBL when creating new state information
- Get UBL's Topology Map to look a little bit better
- Make sure the user doesn't see a blank screen when doing Mesh Editing.
* Huh??? GitHub Desktop screwed up!
* get the planner object in scope
* Fix out of scope z_fade_height
* Travis timed out...
I need a change so I can force a new commit and sync.
8 years ago
3b4116e73b
missing enable for M605 for duplication mode
...
I believe gcode_M605 will not be called when using DUAL_NOZZLE_DUPLICATION_MODE without this change.
8 years ago
5e8892d6b5
Show Restore Failsafe item with EEPROM off
8 years ago
76af9ac7c5
tweaks
8 years ago
ba5910ab6c
Constrain LCD status message rendering
8 years ago
2c309a8f7c
Fix set_lcd_contrast
8 years ago
22dbb2117c
Merge pull request #6812 from thinkyhead/bf_day_ending_in_y
...
Cleanup code, organize & document fastio pin mappings
8 years ago
364f8fb613
Update Configuration.h files to better names ( #6814 )
...
Changed UBL_G26_MESH_EDITING to UBL_G26_MESH_VALIDATION
Added UBL_MESH_EDIT_MOVES_Z to prepare for that change (coming next)
8 years ago
d7fda2fe49
Formatting, const in G33
8 years ago
1519b0e7c1
Split up fastio.h, document pin mappings
8 years ago
49599caade
General cleanup to utf_mapper.h
8 years ago
02f15f6775
UBL-related cleanup, spacing, standards
...
Reference: #6804
8 years ago
52e20aeab3
Pins-related cleanup, formatting
8 years ago
ea906e4da7
Merge pull request #6810 from thinkyhead/bf_lcd_live_editing
...
Add "live editing" option to LCD menus
8 years ago
11fc9564c9
Add live editing option to LCD menu
8 years ago
8a0a5cfccc
Temp-related cosmetic changes
8 years ago
b29dbbd5e4
Use uint16_t for temps
8 years ago
ebcd1aaf88
Access hotend/bed temperatures as float
8 years ago
6ce2b1ff4a
G33 evolutionary changes
8 years ago
3c061a9f9a
UBL tabs, whitespace, spelling, etc.
8 years ago
75badae2f8
Disable PROBE_MANUALLY for UBL
...
Plus some other UBL tweaks.
8 years ago
94a4af1d7f
Merge pull request #6773 from thinkyhead/bf_lcd_patch_e5
...
Patch LCD code for 5th extruder
8 years ago
01f452c37c
Tweak Azteeg X3 PRO _pins.h so Viki2 will work for those without a case light.
...
- add comment explaining that the Panucatt Viki2 wiring diagram uses pin 44
8 years ago
e09b4ce4a5
Add checking
8 years ago
13599a73c7
Add `G7` gcode command to move between UBL mesh points
...
- can be augmented in the future to enable for other leveling systems
Quite simple, but did not want to modify `G1` as the additional checking would slow it down.
Tested & working.
8 years ago
43c24f0027
Fix recent regressions, &c.
...
- fix broken `M421` due to less-than-careful optimization
- add HOME_AFTER_DEACTIVATE define to advanced config so not everyone has to rehome after steppers are deactivated
- misc. cleanups (remove unused label, unused variables)
8 years ago
3843a5151a
Patch LCD code for 5th extruder, EEPROM reset
8 years ago
6c064bb7d6
Some probe_pt error-handling
8 years ago
3370329751
Fix broken EEPROM save/load
8 years ago
f0fe26c411
Ensure Arduino.h and configs are included for serial.cpp
8 years ago
ffb5353294
Merge pull request #6738 from thinkyhead/bf_config_crc_rebase
...
Implement CRC16, develop mesh allocation table
8 years ago
e806e6419a
Merge pull request #6768 from thinkyhead/rc_spindle_m3_m5
...
Spindle / Laser support
8 years ago
d6f49c6626
Merge pull request #6752 from jdelahayes/bugfix-1.1.x
...
Update french language
8 years ago
55a87da036
SPINDLE/LASER implementation
8 years ago
ffe0e2d19a
SPINDLE/LASER pins changes
8 years ago
99c4900a98
SPINDLE/LASER config changes
8 years ago
a3abfeac47
Mark strings needing translation
8 years ago
7f4e4b1212
UBL name/state methods
8 years ago
7852369987
Implement CRC16, develop mesh allocation table
...
- Add crc16 utility function
- Implement CRC16 for config store, remove old checksum, increment layout version
- Move UBL mesh store/load to MarlinSettings; increment UBL_VERSION
- Begin to lay out MAT structure, prototype functions, etc.
- Rename ubl.state.eeprom_storage_slot to .storage_slot
- Misc. optimization
- Cleanup/standardize/improve some messages
This is a work in progress!
8 years ago
00d358d92d
Fix a PROBE_MANUALLY bug in ultralcd.cpp
8 years ago
c2321b1cdd
Separate SWITCHING_NOZZLE and SWITCHING_EXTRUDER
8 years ago
238fb53617
Patch home_all_axes to ignore G28 XYZ parameters
8 years ago
6b6630e11b
Clean up trailing whitespace and tabs
8 years ago
d30e478f97
Fix incorrectly optimized find_closest_mesh_point_of_type() function ( #6761 )
8 years ago
5a9e52a3e0
Use COPY_XYZE macro to copy exactly 4 elements ( #6758 )
...
Fix undefined DELTA_PROBEABLE_RADIUS for UBL_DELTA
8 years ago
8606644343
M48 Fix for Delta Configuration Files & UBL G29 only homes when necessary ( #6757 )
...
* Fix M48 for Delta's There was a scope issue: DELTA_PROBEABLE_RADIUS wasn't getting defined.
* Check if the specified G29 command requires homing
8 years ago
0cd398c25d
UBL Menu Updates ( #6751 )
...
Things should be pretty stable for a while.
But it wouldn't surprise me if the Delta people have a need for a few special commands.
8 years ago
a5737cba7c
Update french language
8 years ago
0fef9a2983
Remove "ubl." prefix from calls within ubl method
8 years ago
14a4257c7b
UBL tabs, whitespace, spelling, etc.
8 years ago
56e2e331ed
UBL G29: replace 'O' with 'T'
...
Since we already used 'T' for `G29` Topology Report in the past, and since 'T' is available…
8 years ago
091f94a6bf
Fix up M421 and some comments
8 years ago
4ec4ecff1a
Reduce find_closest_mesh_point_of_type a little
8 years ago
f1a1c6873e
Patch lcd_implementation_status_screen compiler warning
8 years ago
2266c0780d
fixed spanish lang
...
It was missing MSG_FILAMENT_CHANGE_HEAT_2 and MSG_FILAMENT_CHANGE_HEATING_2
8 years ago
b213a45efb
UBL_DELTA post merge cleanup ( #6705 )
...
* UBL_DELTA post merge cleanup:
fix fade_height, lost during some previous merge
fix float cx,cy which are not const
move repeated z_cxcy calc line inside loop
style fixes and comment fixes/alignment
* Update ubl_motion.cpp
remove unnecessary parentheses
* Update Conditionals_post.h
Change name of define to more accurate meaning:
UBL_GRANULAR_SEGMENTATION_FOR_CARTESIAN
which is not and should not be the default for cartesians with UBL.
8 years ago
6f86c46fa6
Fix typo that caused scope issues for DELTA ( #6750 )
8 years ago
1fbcbc05f6
UBL no longer flout's the sacred GCode standard ( #6745 )
...
Also clean up ubl_motion.cpp debug info and fix declaration of cx & cy
8 years ago
c262ea92e0
Merge pull request #6733 from abusca/Euskera
...
Updated Basque translation
8 years ago
267f77b18b
More constraint on axis_unhomed_error
8 years ago
645096b87a
Updated Basque translation
...
Updated Basque translation with new strings.
8 years ago
40d95a4e23
Update the gMax files to display better with Proportional Fonts ( #6727 )
...
Update the gMax files to display better with Proportional Fonts
8 years ago
c06af63f87
G26's default behaviour ought to be the entire mesh ( #6726 )
...
Adding the capability to specify ahead of time how much of the validation pattern to print made it so by default G26 only did one circle and no connecting lines.
It is more natural for the unsophisticated user to just do the entire mesh (bed). We default the repetition count to GRID_MAX_POINTS+1 to insure we get every last one of them!
8 years ago
15040821e0
Setup FolgerTech-i3-2020 files better for the user ( #6724 )
...
UltiPanel was enabled, but technically, it is a REPRAP_DISCOUNT_SMART_CONTROLLER
Either configuration works on the machine. But we want it 'Right'.
Setup the Proportional Font spacing so columns line up nicer on PronterFace and Repetier Host.
8 years ago
67c9b1e332
Update M665 comment, fix M665 code_value code.
8 years ago
37399e3cb5
Fix prepare_move_to_destination_cartesian for UBL
8 years ago
a7fb55ea6d
Use GRID_MAX_POINTS. Some formatting
8 years ago
e51b5774db
Merge pull request #6699 from mtowara/patch-1
...
Bugfix PRINTER_EVENT_LEDS
8 years ago
056350d9bf
Merge pull request #6656 from FHeilmann/fix_fwretract_pos_z_move
...
Fix FWRetract with positive z-moves during retracted state
8 years ago
0e582bcfb7
Fix #6691 - redundant line in M665
8 years ago
68ae7c8d7a
Bugfix PRINTER_EVENT_LEDS
...
Extra closing curly bracket terminates while loop early if PRINTER_EVENT_LEDS defined
8 years ago
ba29da56e0
Add disclaimer for verboten parameters
8 years ago
0696dda470
Cleanups to UBL_DELTA
8 years ago
cbfca29522
M421 tweaks, just to use const
8 years ago
233f824dd6
Define GRID_MAX_POINTS
8 years ago
b17e2d3dcd
Apply const in Marlin_main.cpp
8 years ago
92fbea2906
Add some GCodes to the header of Marlin_main.cpp
8 years ago
94e90ca26c
Tweak M80/M81 descriptions
8 years ago
ee50dfaaf3
Adjust G26 arguments
8 years ago
b0ba5cae73
Fix a spelling boo
8 years ago
91841d75c9
UBL_DELTA ( #6695 )
...
UBL on Delta's.... Should be close! Should not affect any Cartesian printer.
8 years ago
445003dbb8
Merge pull request #6694 from bgort/g29p2b
...
UBL: Minor improvement to G29 P2
8 years ago
5a5dba6fc8
UBL: Minor improvement to G29 P2
...
- allow H code value to override probing height
- minor cleanups
8 years ago
ae676490c9
M421: Add 'adjust closest point' capability
...
- Split M421 into separate versions for bilinear and ubl
- Fix minor issue in G26
8 years ago
9a688d1456
Merge pull request #6682 from thinkyhead/bf_M80_s_arg
...
"M80 S" to report the state of the PSU pin
8 years ago
b63e82f309
M421 Mesh Point Offset and misc. UBL clean up ( #6685 )
...
* M421 Mesh Point Offset and misc. UBL clean up
Allow M421 to accept an offset as well as absolute value for a specified
mesh point.
And misc. UBL clean up to reduce redundent code.
* Better error checking for M421
* Fix M421 Y index bug
I just noticed.... We've had a Y index bug for who knows how long?
8 years ago
539e0c2f31
"M80 S" to report the state of the PSU pin
8 years ago
df42428281
Merge pull request #6665 from bgort/font
...
Add proportional font adjustment ratio
8 years ago
2604742191
Add proportional font adjustment ratio
...
- update example configs
8 years ago
b3407a371b
Merge pull request #6676 from bgort/g26zhop
...
G26: Add 0.5mm Z-bump between circles to minimize pattern scraping
8 years ago
c33d99c5b2
Merge pull request #6680 from bgort/g26repeat
...
G26: Add 'Repeat' Option
8 years ago
7325035aac
Merge pull request #6637 from Tannoo/UBL_Menu_System_1.1
...
UBL Menu System 1.1
8 years ago
f7a201b0d0
G26: Add 'Repeat' Option
...
- Allows for specifying number of points to print/validate, using 'R' code like with G29 P4 Rx
- Moved the code for Random to 'M' so we could be consistent with G29 P4
- G26 instructions indenting/cleanup
8 years ago
9c5957fc77
G26: Add 0.5mm Z-bump between circles to minimize pattern scraping
8 years ago
4da14b14f4
UBL Cleanup/Bugfix
...
- Fix bug in ubl_line_to_destination
- Improve/fix output of some ubl.h functions
8 years ago
66db6c3acc
UBL Menu System 1.1
...
/**
* UBL System submenu
*
* Prepare
* - Unified Bed Leveling
* - Activate UBL
* - Deactivate UBL
* - Mesh Storage
* Memory Slot:
* Load Bed Mesh
* Save Bed Mesh
* - Output Map
* Map Type:
* Output Bed Mesh Host / Output Bed Mesh CSV
* - UBL Tools
* - Build Mesh
* Build PLA Mesh
* Build ABS Mesh
* - Build Custom Mesh
* Hotend Temp:
* Bed Temp:
* Build Custom Mesh
* Info Screen
* - Build Cold Mesh
* - Fill-in Mesh
* Fill-in Mesh
* Smart Fill-in
* Manual Fill-in
* Info Screen
* Continue Bed Mesh
* Invalidate All
* Invalidate Closest
* - Validate Mesh
* PLA Mesh Validation
* ABS Mesh Validation
* - Custom Mesh Validation
* Hotend Temp:
* Bed Temp:
* Validate Mesh
* Info Screen
* - Edit Mesh
* Fine Tune All
* Fine Tune Closest
* - Adjust Mesh Height
* Height Amount:
* Adjust Mesh Height
* Info Screen
* - Mesh Leveling
* 3-Point Mesh Leveling
* - Grid Mesh Leveling
* Side points:
* Level Mesh
* Info Screen
* - Output UBL Info
*/
8 years ago
3b0127cf8e
Fix compiler complaint related to M100
8 years ago
11104f177b
Apply const in BABYSTEPPING
8 years ago
081bf1f879
Patch #else / #endif comments
8 years ago
a9487c9443
Reduce redundancy in BLTOUCH conditionals
8 years ago
8d961b51cc
Eliminate M100 compiler warnings?
8 years ago
efb9ce24d9
Merge pull request #6645 from tcm0116/bltouch_config
...
Automatically define Z_MIN_PROBE_ENDSTOP_INVERTING for BLTouch
8 years ago
e2f07917ab
Merge pull request #6644 from tcm0116/bltouch_menu
...
Move BLTouch LCD menu from Main to Main/Control
8 years ago
fe96376a73
Fix FWRetract with positive z-moves during retracted state
8 years ago
47cae2929f
Patch platformio.ini to fix build error in DevIoT
...
For compatibility with DevIoT, until that can be solved.
8 years ago
911a87e006
Disable SCARA feedrate scaling by default
8 years ago
71396f77d3
Cleanups following recent commits
8 years ago
dca48f0e63
Move platformio.ini back to Marlin folder - it works there
8 years ago
a6dafb058e
Small reduction in error code size
8 years ago
a1e04942a2
Cleanup to software PWM variables
8 years ago
a20d0794e6
Automatically define Z_MIN_PROBE_ENDSTOP_INVERTING for BLTouch
8 years ago
3279337f47
Move BLTouch LCD menu from Main to Main/Control
8 years ago
6cb0fa4128
Cleanup previous implementation of new quiet probing
...
Saves a few lines of code.
8 years ago
4b7f8ad9c6
Merge pull request #6610 from bgort/pio-improvements2
...
PlatformIO-related changes
8 years ago
56ca47ab9d
Patch configuration temp units
8 years ago
421dd62800
Adjust spacing of "spaces"
8 years ago
26dba44cd3
Patch redundant lcd settings
8 years ago
34b5041576
Spacing adjustment, ubl_G29
8 years ago
1c4ed8b106
Note 5 extruders in config comments
8 years ago
6e4a5cc8c6
Patch missing const in temp_abs
8 years ago
d35e2fda10
Merge pull request #6622 from bgort/silentprobing
...
Improve BLTOUCH_HEATERS_OFF functionality
8 years ago
6ed52fb765
Adjust spacing in LSF
8 years ago
110afff415
More misc UBL fixes and update gMax examples ( #6632 )
...
I think I forgot to Sync before I committed last time. Some UBL
changes did not stick.
Also, update the gMax configuaration.h file so other than unique numbers
and settings, it exactly matches the default configuration.h file.
8 years ago
d92fa40c62
misc. UBL fixes ( #6631 )
...
* Restore LSF functionality
Some of the typo's persisted... Hopefully this gets them all fixed.
* Restore user's expectations of how G28 should behave
* Allow Nozzle size control with ornery host programs
8 years ago
faa270071d
Improve BLTOUCH_HEATERS_OFF functionality
...
- rename to PROBING_HEATERS_OFF
- move heater pausing functionality into thermalManager
- add variables, pause(), ispaused(), other functions
- add fan pausing functionality -> PROBING_FANS_OFF
- add probing_pause() wrapper
- move pausing into do_homing_move() and do_probe_move() to minimize quiet time and so other probe types can benefit
- example configs
8 years ago
d66e9efac5
G29 P1 stops reporting Invalid location with this patch
8 years ago
ce507deb9f
Support temperature units in M503
8 years ago
a59066bca9
Various improvements - mostly UBL-related ( #6607 )
...
UBL Clean up.
8 years ago
0446dd3ad8
PlatformIO-related changes
...
- move platformio.ini out of source directory to be more consistent with 'normal' PlatformIO usage
- facilitates IDE integration
- add related .gitignores
8 years ago
77769e284f
Edit configuration comments
8 years ago
6876e79d42
Tweak command index increment
8 years ago
7fcb5c1424
Minor fix in K8200 readme
8 years ago
267f3a03d9
Fixed USE_CONTROLLER_FAN #define usage
8 years ago
ae7c602031
fix error in M105 output -- use SERIAL_PROTOCOL for ints instead of SERIAL_PROTOCOL_F ( #6584 )
...
also removed wayward 'address of' ampersand in setTargetHotend and setTargetBed parameters
8 years ago
3cd9af2409
bugfix-1.1.x ReadMe, Version, helper scripts
8 years ago
15268770f5
Fix broken fwretract recovery extruder feedrate
...
When both lowering and recovery are performed using the same "prepare_move_to_destination()" the extruder recovery feedrate ends up being ignored and, instead, is only capped by either the maximum e-speed or the time it takes to perform the z-lowering.
Performing the two moves separately from each other ensures a correct recovery feedrate.
8 years ago
58210c3a19
Merge pull request #6568 from thinkyhead/rc_bilinear_extension
...
Add EXTRAPOLATE_BEYOND_GRID option to bilinear leveling
8 years ago
da08e11acd
Add EXTRAPOLATE_BEYOND_GRID option to bilinear leveling
8 years ago
6834e36871
Merge pull request #6567 from thinkyhead/rc_sdcard_stop
...
Shutdown heaters, autotemp on SD Cancel
8 years ago
399efd66ed
Click to resume
8 years ago
1196e3ca59
SDCard print completion can use "M0"
8 years ago
6854f08d22
Shut down autotemp in disable_all_heaters
8 years ago
acec237092
Shutdown heaters and fan after canceling a print from the SD card
8 years ago
11b6a3cbb6
Fix regression in least_squares_fit.cpp
8 years ago
e1b85ff67b
Merge pull request #6559 from thinkyhead/rc_more_optimal
...
Compact smart_fill_mesh slightly
8 years ago
9890141f7b
M100 tweak
8 years ago
2658cc707a
Treat temperature as integer, when possible
8 years ago
1b2c7ec20a
Make G26 compatible with inches and thermal unit modes
8 years ago
241bdffe65
Dress up Bilinear Leveling code
8 years ago
67ecf06cc4
Patch issue in gcode_M900
...
Noted in #6550
8 years ago
de5e485ed7
Explicit upward angle solution
8 years ago
ecdf68735f
Compact smart_fill_mesh slightly
8 years ago
628391304f
Merge pull request #6552 from thinkyhead/rc_more_ubl_cleanup
...
Further cleanup of UBL
8 years ago
902fe76db9
Merge pull request #6556 from thinkyhead/rc_use_controller_fan
...
Implement USE_CONTROLLER_FAN as a feature
8 years ago
7ba7474a73
Drop extra parens from address-of operator
8 years ago
0bf5add075
Use UBL_MESH_(MIN|MAX)_[XY] for G29 move limits
8 years ago
b8ba3b7647
Use 'sq' macro where possible
8 years ago
66eba3346b
Remove G29 lcd control debugging
8 years ago
3517154135
Reduce code size, fix bug in smart_fill_mesh
8 years ago
c4e34adcf1
Apply formatting, coding standards to UBL
8 years ago
f4239e62b1
Merge pull request #6557 from thinkyhead/rc_hotend_status_item
...
Keep refreshing LCD if hotend status is on-screen
8 years ago
fc857c5b78
Merge pull request #6549 from thinkyhead/rc_bltouch_refix
...
Fix BLTOUCH_HEATERS_OFF bug
8 years ago
b39f634252
Continuously update LCD when hotend status is displayed in Filament Change screens
8 years ago
2c13922c46
Implement USE_CONTROLLER_FAN as a feature
8 years ago
492bc536bf
Modify debug methods to take PSTR
8 years ago
e5a27d9f36
G29 P2 & P4 bug fixes & improvements
8 years ago
b93be716cf
Remove trailing whitespace
8 years ago
76eca9732d
Fix mis-named language string define in Dutch
8 years ago
806f670092
Merge pull request #6511 from Bob-the-Kuhn/UBL--G26-minor-improvements
...
UBL: G26 minor improvements
8 years ago
0803c9d997
Merge pull request #6533 from thinkyhead/rc_autocal_patches
...
General cleanup of G33
8 years ago
ff5fed137f
Fix BLTOUCH_HEATERS_OFF bug
8 years ago
ca1dd739a3
Organize ubl.h defines by the files they serve
8 years ago
0449f69179
Cleanup patch to recent merge
8 years ago
da2abad636
Various cleanups of G33
...
- update comment section
- redefined P5 grid
- minor clean to probe radius routine
- updated EEPROM version to V37 according remark in #6517
8 years ago
7ce613db0a
Fix Conditionals test for endstop plug used by Z2 or probe.
8 years ago
ef750ae86b
Towards supporting Z2 in Endstops::report_state
8 years ago
c03c623951
Sanity-check Z2 endstop assigned to a nonexistent pin.
8 years ago
70f31b6c76
Throw an error if no E stepper is free for X2, Y2, Z2
8 years ago
ac69eca586
Merge pull request #6538 from bgort/ubl_gridlbls
...
Fix, cleanup, prettify `G29 O` output
8 years ago
99b11db1a1
Merge pull request #6537 from thinkyhead/rc_cleanup_sunday
...
Various leveling-related patches
8 years ago
41e63bbb7c
Fix Horizontal and Vertical UBL optimization bug. ( #6540 )
...
* Fix Horizontal and Vertical optimization bug.
And drastically reduce the debug code foot print....
* Yeah Baby!
The debug print is going A - OK !
8 years ago
e79b335367
Patches for leveling reactivation in G28 / M48
8 years ago
92e22c3bf2
Fix, cleanup, prettify `G29 O` output
8 years ago
7d5cd7e0d7
Tweak set_bed_leveling_enabled
8 years ago
ed81e9b3d3
Adjust leveling conditionals
8 years ago
a64e5659ce
Clean up G26 external references, private vars
8 years ago
2887c20788
Add a function to home all axes (i.e., gcode_G28)
8 years ago
8f895d5e01
Merge pull request #6530 from thinkyhead/rc_cleanups_2
...
Fixes for DUAL_NOZZLE_DUPLICATION_MODE
8 years ago
8002672938
Fixes for DUAL_NOZZLE_DUPLICATION_MODE
8 years ago
f69acde966
Merge pull request #6528 from MarlinFirmware/revert-6416-negative-mesh-fix
...
Revert "Fix for Meshpositions if printer has negative endstop positions"
8 years ago
4803a4322e
Revert "Fix for Meshpositions if printer has negative endstop positions"
8 years ago
4f74c416a4
Patch for BLTOUCH_HEATERS_OFF
8 years ago
1823a6ea29
Patch for missing DELTA_HEIGHT
8 years ago
d814e468d2
Fix set_heaters_for_bltouch and usage
...
- Only call `set_heaters_for_bltouch` when actually deploying/stowing
- Clear `next_emi_protection` when re-enabling heaters
8 years ago
4e1448e75a
Various fixes for compiler warnings
...
add BLTouch-related messages in english and (rusty) french;
add missing endstops.h in ultralcd.cpp;
fix misc. compiler warnings;
fix lsf_reset - ZERO macro can't handle a pointer as it would only memset the size of the pointer, not the size of the entire struct
8 years ago
fc9919b749
Merge pull request #6515 from thinkyhead/rc_cleanup_sunday
...
Some minor cleanups to code formatting
8 years ago
c12bc51a59
cardreader.cpp spacing tweak
8 years ago
46b714a52f
Cleanup spacing in pinsDebug.h
8 years ago
88141ca717
Remove things that aren't pins from pinsDebug_list.h
8 years ago
ff35b11d08
Resolve compiler complaint about memset volatile *
8 years ago
0b421e97c9
Rename some (unused) OMCA pins
8 years ago
c2c9f01c8e
Patch newly-introduced bug in IS_Z2_OR_PROBE
8 years ago
819df5e06d
Cleanups to pins debugging
8 years ago
42824b0e1f
Use new serial spacing function to save PROGMEM
8 years ago
cd72901fb7
Cleanups to UBL code
8 years ago
ce87c7803e
implement G26 changes per review
8 years ago
769817ce5e
Need to define this for Rigidboard V2
...
Motor current defaults need to be defined for Rigidboard
8 years ago
39c6c5621b
Merge pull request #6416 from SkyNet3D/negative-mesh-fix
...
Fix for Meshpositions if printer has negative endstop positions
8 years ago
671a44b8aa
Merge pull request #6410 from teemuatlut/LVD-Delta
...
Delta auto-calibration updates
8 years ago
5d5c9a040a
Merge pull request #6509 from thinkyhead/rc_config_patches
...
Configuration cleanup
8 years ago
d480b6f75a
Enable E1 stepper for DUAL_NOZZLE_DUPLICATION_MODE
8 years ago
dcde202157
Add startup notice & update host temperatures while waiting
...
Right now G26 doesn't send a notice to the host that it's running. It's
not until the heaters are at temperature that you know for sure if it's
running or not.
Added host temperature prints so that someone watching the host
interface will see the temperatures change during the warm up period.
Updates are sent every 5 seconds.
8 years ago
54751e8557
Put DISTINCT_E_FACTORS adjacent to the affected settings
8 years ago
0dbe4b3e54
Edit configurations to reduce verbosity, arrange logically
8 years ago
0750933bc6
Merge pull request #6490 from Bob-the-Kuhn/Missing-X-stop
...
Endstop not enabled if pin is zero
8 years ago
5ace3699b1
Output (commented) coordinates on G29 S-1; helps identify the x/y points that correspond with i/j coordinates, which eases manual tweaking of z values ( #6507 )
8 years ago
d7d4378481
Remove inaccurate version description
8 years ago
f169c04604
Merge pull request #6491 from thinkyhead/rc_cleanup_wednesday
...
Various cleanups for recent merges
8 years ago
6d63255ddc
Merge pull request #6508 from bgort/pio_improvements
...
PlatformIO-related improvement
8 years ago
cafc48dff8
little oops
8 years ago
627730948d
Add U8glib as a dependency to platformio.ini for those who use PlatformIO; this makes compiling even easier as u8glib will be downloaded and included automatically.
...
Also added the new .pio-related directory to .gitignore, and a few ignores for those who use cmake.
8 years ago
5974d8e168
change G26 default nozzle size to 0.4, consistent with instructions ( #6506 )
8 years ago
471a321624
leaner code for probe routine
8 years ago
3c0d5ba0a1
allow idle() to be called - fixes sometimes crash/hang in G29 I; ( #6505 )
8 years ago
2509587b5a
Correct over optimization of pre-initialized variables ( #6500 )
...
* Correct over optimization of pre-initialized variables
NEAR_ZERO() works most of the time... But it leaves corner cases
uncovered. We need to explicitly check if these variables are +/-
infinity.
* Correct over optimization of pre-initialized variables
8 years ago
585c00a728
Proposed changes
...
This is what I did yesterday:
- basicly gave the tests more comprehensive names; put all the
declarations at the top; got rid of the magic negative C-value (renamed
to P + A, O, T)
- "cos(RADIANS(180 + 30 * axis)) * (1 + circles * 0.1 * ((zig_zag) ? 1 :
-1)) * delta_calibration_radius" compiles wrong is zig_zag statement is
without brackets
- DELTA_TOWER_ANGLE_TRIM reset to 3 values (the calcs use the 3th value
to normalize will not compile otherwise)
-Wrote 3 dummies to keep EEPROM lenght the same
-Reset the configs to the 'original' with autocal + menu disabled (but
can be enabled of course)
8 years ago
29fa241617
Initial patches to G33
8 years ago
12ce051b55
Add a function to output spaces to serial
8 years ago
42f4c53254
Starting on G33 rewrite
8 years ago
baf3b91460
DELTA_TOWER_ANGLE_TRIM only needs AB
8 years ago
27cd165adf
Last three Spanish language strings
...
Updates as per @thinkyhead request.
8 years ago
2cc9774f34
Apply bltouch_menu
...
As proffered in #6252
8 years ago
1a111180de
Clean up set_heaters_for_bltouch
8 years ago
7db805930a
Cleanup configurations
8 years ago
8bf3a3fcdb
Remove inaccurate comments from ubl.h
8 years ago
47557d5a19
Fix up formatting in ubl.h
8 years ago
0a8e09c723
Clean up excess whitespace, comment formatting
8 years ago
a35c681453
Clean up least_squares_fit
8 years ago
40089249c3
add PIN_EXISTS to HAS_xyz_MIN macro
8 years ago
8020069371
Apply coding standards for indentation
8 years ago
dabca83742
Merge pull request #6437 from Kaibob2/patch-1
...
Update language_de.h
8 years ago
3d0a4c4ea9
Update language_de.h
8 years ago
6bf1d50188
Added missing translations ( #6458 )
8 years ago
404f767d44
Update language_tr.h ( #6463 )
8 years ago
5e701524f8
Update language_cz.h for new translations ( #6465 )
...
* Update language_cz.h for new translations
* Correction translate
* Revert correction back to hotend
8 years ago
0a92ce7a98
Completed french translation ( #6475 )
8 years ago
ff4fb42e7d
Add new strings as per recent changes in RCBugFix ( #6482 )
...
Adding missing strings to Spanish language, as per changes recently
done to the RCBugFix branch.
8 years ago
67d1fc5556
Update language_nl.h ( #6478 )
...
updated the RCbugfix release with additional Dutch translations
8 years ago
8c6b4537a6
Fix issue in itostr4sign with numbers <100 ( #6487 )
...
The first character in the string wasn't blanked if the number went from >= 100 to <100, resulting in artefacts in the displayed string.
8 years ago
4ea8d0f89b
Solved "The Travis CI build failed "
8 years ago
ed6b361e27
cleanup ready to squash
8 years ago
7a6a1ef583
M666 normalize positive values to <=0
...
M666
+ tower radians absolute value
8 years ago
4075b95519
Allow BL-Touch users to control heaters during probe event ( #6485 )
...
The Configuration.h file entries for BL-Touch have been updated to:
```cpp
//#define BLTOUCH
//#define BLTOUCH_DELAY 375 // (ms) Enable and increase if needed
//#define BLTOUCH_HEATERS_OFF // if defined the printer's heaters are
turned off during probe event
```
8 years ago
6e8ecb908a
Shut down heaters during BL-Touch probe event
...
The electro-magnetic interference from the bed and nozzle are affecting
the BL-Touch repeatability for some users. This problem can be helped
by shutting down the heaters during the actual probe event and then
quickly turning them back on.
Because this code is messing with the heaters, it is written in a
paranoid manner. It only turns the heaters back on if everything is
EXACTLY as it expects things to be. The BL-Touch probe must have been
put into a deployed state less than 20 seconds prior, or the stow()
function will NOT turn the heaters on.
This code has been tested and works for both G28 and probing functions.
8 years ago
d8102aeca8
Cn negative : no tower angle calibration
...
Giving a negative number of probe points disables the tower angle
correction calibration ('4point' instead of '7point' solution)
EEPROM version updated
8 years ago
3601f08e87
Better tuned FolgerTech i3-2020 example file
8 years ago
a20b7d9581
Better tuned Example file for FolgerTech i3-2020
...
Also setting up Z-Probe on the machine.
8 years ago
bf2fe46062
Update language_de.h
8 years ago
11d34be060
Update language_de.h
8 years ago
817ecb9ff4
Merge pull request #6453 from thinkyhead/rc_cleanup_wednesday
...
Minor cleanups, work-in-progress
8 years ago
22f6e277af
Get example files fully into compliance
...
Change to support new name GRID_MAX_POINTS_XY
Start UBL at version 1.0 in the CUSTOM_MACHINE_NAME
8 years ago
a9bc1d30cc
z_offset change
...
Avoids to have to recalibrate the delta_height after a z_offset change
8 years ago
ec26e23e7e
Add my two 'Nice' machines as example configurations
...
These are my two 'Nice' machines. Both are good example machines. The
FolgerTech i3-2020 is probably the best value kit on the market right
now. And it has developed a 'Cult Following' of hobbiests. I'll always
have an up to date Configuration.h file set for it, so it may as well be
an example configuration.
And the gCreate gMax 1.5+ is the best printer I've ever seen that runs
Marlin. For sure, I'll always have up to the minute Configuration.h
files for this printer also. I've moved over to using the gMax as my
primary development machine for Marlin. So... Besides being a good
machine, it is a nice convienience for me to have this Configuration.h
file as an 'Example'.
8 years ago
adb8e68592
Fix stuck "Print Aborted" LCD message
...
Fixes #6393
8 years ago
096b927102
Minor optimization of FILAMENT_WIDTH_SENSOR
8 years ago
5bdb0b567d
Cosmetic patches
8 years ago
38ae7f4238
Added more translation strings
...
There are some quite tricky ones which are hardly translateable.
Maybe @Sebastianv650 can review this
8 years ago
4d96d3eab1
Bootscreen delay after clear, then set chars
...
Fixes #6426
8 years ago
5512130d6c
Only set Compare Mode for channel A
...
Fixes #6445
8 years ago
d467e97679
Smart-Fill and Mesh-Tilting (both 3-point and grid) working!
...
Also... The memory corruption issue may be fixed. The GCC compiler
was inlining static functions and this caused the G29() stack frame to
become much larger than the AVR could handle.
8 years ago
a699967ec8
Merge pull request #6443 from thinkyhead/rc_interrupt_fastio
...
Patch fastio.h with Timer 2 interrupt support
8 years ago
2823bf0874
Update fastio.h with special handling for Timer 2
8 years ago
fd535e111a
Fix up XYZ_CONSTS_FROM_CONFIG macro
8 years ago
03c2f756b9
Update language_de.h
8 years ago
dcf30a69d6
Allowing #define DELTA_TOWER_ANGLE_TRIM[C_AXIS]
...
More consistent with M665 where C-value is allowed as well, then
normalized
8 years ago
f41fb2b635
Numerous UBL-related changes:
...
* relocated ubl state to config. store:
* removed a number of ubl state variables and padding which were largely unused - saved 58 bytes of both SRAM and EEPROM;
* modified ubl sanity_check - no longer checks removed state variables that were otherwise unused, where checking didn't seem to accomplish anything, ultimately;
* removed pre_initialized state, saving 64 bytes of SRAM;
* removed automatic saving of UBL state after UBL activation/deactivation;
* consolidated multiple GRID_MAX_POINTS_X/Y to 'Global Leveling' section of EEPROM;
* minor update to G29 Sx notes/instructions;
* renamed mesh load and save parameter to 'slot' from 'm' for clarity;
8 years ago
f1a4758cef
use progmem instead of sram for mesh_index_to_x/ypos array;
...
fix maximum mesh_index_ array size at 16 (15+1);
8 years ago
87d240042a
Optimize number-to-string functions, no-fan display
8 years ago
959566cf0a
Update note about M163 / M164
8 years ago
830851df13
Spend some SRAM to optimize bilinear leveling
8 years ago
091179d960
bed_level_grid => z_values (also *_virt array)
8 years ago
23cdbbb2d3
Add a method to refresh bilinear bed level after a change
8 years ago
ccda63c473
Drop the accessor form for LCD value editing
8 years ago
10da175be5
Fix a pair of compiler complaints
8 years ago
ff0018e287
Format hex values as uppercase
8 years ago
77aa16005d
Polish font
...
Add polish font for GLCD displays only.
HD44780 work properly without polish character.
Update language_pl.h.
8 years ago
244f67590e
Delta probe height bug solved
8 years ago
406a83ff2d
Fix for Meshpositions if printer has negative endstop positions
8 years ago
3ed737425d
Fix typo in new SET_COM macro
8 years ago
88649b06a6
use planner.z_fade_height, etc. instead of private, ubl-specific g29 fade height
8 years ago
004928148c
Tower angles
...
Adding '7-point' tower angle correction calibration
8 years ago
76ec7a0f80
Adding upto 7*7 probe grids
...
- adding Cn 5, 6 and 7
8 years ago
d4f593d200
Delete 'expert level'
...
and getting rid off verbose level 3 and configuration_adv settings
8 years ago
13c8493878
M665 rework and related issues (all delta's)
...
- Making M665 compatible with repetier (see
http://reprap.org/wiki/G_code#M665:_Set_delta_configuration )
- M665 B also sets the radius for manual calibration menu
- Converting tower ajustment definitions to arrays - tower angle
corrections compatible with Esher 3D wizzard
- Only tower angles need to be adjustable with M665 and stored to EEPROM
- tower radius and diag rod can be adjusted in the FW only with #define
8 years ago
e0e069c6d8
Clean up trailing whitespace
8 years ago
9b94210394
Bring FLSUN config more up to date
8 years ago
b0aa256bc0
Updates for all configs
8 years ago
ee46ce1743
Add and apply interrupt helper macros
8 years ago
6131c62499
General cleanup
8 years ago
2c86dfd3b5
Fix compiler type conversion errors after LCD changes
8 years ago
55f9e76610
Merge pull request #6367 from thinkyhead/rc_cleanup_followup
...
Cleanup after some direct commits
8 years ago
d38a792a91
Merge pull request #6382 from MagoKimbra/fix_configuration_store
...
Fix double definition in configuration_store
8 years ago
b98bc034ae
Replace c_assert hack with static_assert
8 years ago
5eb2b1a790
Clear up G29 compiler warnings
8 years ago
4ce2a63db0
Apply const, spacing to Marlin_main.cpp
8 years ago
e97f1284c1
Cleanup of pins testing code
8 years ago
e9b53ae00c
Cleanup after some direct commits
...
https://github.com/MarlinFirmware/Marlin/commit/5e9726530ff21d3bc62beaa6
ac1b9437c276130a
8 years ago
e05d050a1e
Add hex routine to print an address
8 years ago
4542282f5e
Fix broken TOGGLE macro in fastio.h
8 years ago
ed52275a14
Fix double definition in configuration_store
8 years ago
de569e3d4e
Merge pull request #6327 from Bob-the-Kuhn/M43-toggle-&-Z-probe-fixes
...
M43 Toggle & Z servo test - fix bug & add another check
8 years ago
f33a650ecc
Merge pull request #6368 from thinkyhead/rc_linear_advance_eeprom
...
Add Linear Advance values to EEPROM and LCD
8 years ago
a00ae4790a
Replace M905 with unique code M900
8 years ago
1286d9603d
Clean up and organize ultralcd.cpp
8 years ago
3cdf78a79f
MSG_VOLUMETRIC => MSG_FILAMENT
8 years ago
f8e77d6545
Add Linear Advance values to EEPROM and enable configuration of K via LCD
8 years ago
eb2d073dae
Add M905 R for setting the E/D ratio directly
8 years ago
69dfa54a84
Use code_value_linear_units for known-linear axes
8 years ago
b956f2642b
Show M503 report with current linear units
8 years ago
ba4a005ceb
Merge pull request #6373 from mtowara/mt_makefile_fix
...
Fix Makefile build
8 years ago
150b15c311
fix compiler errors generated by more stringent flags in Makefile:
...
- use volatile for registers
- avoid implicit casts
8 years ago
f6095c9325
fix missing serial.cpp in Makefile
8 years ago
871f92378c
Tweak headings in EEPROM structure
8 years ago
bf2548be4a
Merge pull request #6362 from tcm0116/babystepping
...
Only queue babysteps if axis is in a known position
8 years ago
9c410ddf68
Fixed an issue where a display with a hardware reset pin (LCD_RESET) may not get initialized properly.
8 years ago
72a7fac461
Only queue babysteps if axis is in a known position
8 years ago
5e9726530f
Setup to find data corruption and general clean up
...
This data corruption problem is very difficult. Just changing the code
a little bit changes whether the problem even happens and what is
affected. I need these changes in the main branch so I can operate with
the extra debug code always available and turned on.
Everything is setup such that if M100 is turned off or DEBUG(ECHO) is
turned off, the code is not affected. M100 has been made a little bit
more inteligent so it can display the serial command buffers in a more
meaningful way (because the data corruption seems to often times end up
in that area).
8 years ago
e519e95953
Merge pull request #6358 from thinkyhead/rc_doubleclick_fix
...
Show Cancel/Continue screen for ABL "Level Bed"
8 years ago
a81606c680
Show Cancel/Continue screen for ABL "Level Bed"
8 years ago
51021bc7b8
Merge pull request #6353 from thinkyhead/rc_endstop_coolness
...
Clean up endstop triggering code
8 years ago
857dec0990
Merge pull request #6342 from benlye/benlye-fix-softspi
...
Fix softspi variant conditional for 1284p
8 years ago
4e04383d18
Merge pull request #6354 from thinkyhead/rc_doubleclick_fix
...
Fix undefined symbol if DOUBLECLICK_FOR_Z_BABYSTEPPING and HAS_BED_PROBE defined
8 years ago
8dd0492e68
Show lcd_babystep_zoffset screen if DOUBLECLICK_FOR_Z_BABYSTEPPING is enabled and HAS_BED_PROBE is defined
8 years ago
0a2f60fab4
Make spi.h inclusion conditional
...
spi.h is only needed if HEATER_0_USES_MAX6675 is defined, so making its inclusion conditional on HEATER_0_USES_MAX6675 being defined.
8 years ago
60471b7592
minor improvements
...
Configuration_store.cpp - changed a couple of print statements so the
values were printed. The old method resulted in the formula being
printed.
ubl_G29
1) added support for R option to P4. Now probes all points unless R is
present and the number is greater than 0.
2) P2 - moved map print statement so it showed the point that was
currently being probed, The old location did this only for the first
point.
3) P4 - Moved the map print for the same reason.
ultralcd.cpp - changed "Mesh Editor :" to "Mesh Editor" because the LCD
draw routine puts a ":" in automatically so you end up with an extra ":"
using the old message.
8 years ago
Scott Lahteine