Fix regression in least_squares_fit.cpp

8 years ago · 11b6a3cbb6
parent e1b85ff67b
commit 11b6a3cbb6
1 changed files with 3 additions and 4 deletions
--- a/Marlin/least_squares_fit.cpp
+++ b/Marlin/least_squares_fit.cpp
@ -69,10 +69,9 @@ int finish_incremental_LSF(struct linear_fit_data *lsf) {
  lsf->x2bar = lsf->x2bar / N - sq(lsf->xbar);
  lsf->y2bar = lsf->y2bar / N - sq(lsf->ybar);
  lsf->z2bar = lsf->z2bar / N - sq(lsf->zbar);
-  lsf->xybar = lsf->xybar / N - sq(lsf->xbar);
-  lsf->yzbar = lsf->yzbar / N - sq(lsf->ybar);
-  lsf->xzbar = lsf->xzbar / N - sq(lsf->xbar);
-
+  lsf->xybar = lsf->xybar / N - lsf->xbar * lsf->ybar;
+  lsf->yzbar = lsf->yzbar / N - lsf->ybar * lsf->zbar;
+  lsf->xzbar = lsf->xzbar / N - lsf->xbar * lsf->zbar;
  const float DD = lsf->x2bar * lsf->y2bar - sq(lsf->xybar);
  if (fabs(DD) <= 1e-10 * (lsf->max_absx + lsf->max_absy))
    return -1;