HAL FastIO cleanup and fixes

Marlin/src/HAL/HAL_LPC1768/fastio.h

@@ -55,7 +55,7 @@ bool useable_hardware_PWM(pin_t pin);
 #define WRITE_PIN_CLR(IO)       (LPC_GPIO(LPC1768_PIN_PORT(IO))->FIOCLR = LPC_PIN(LPC1768_PIN_PIN(IO)))
 
 #define READ_PIN(IO)            ((LPC_GPIO(LPC1768_PIN_PORT(IO))->FIOPIN & LPC_PIN(LPC1768_PIN_PIN(IO))) ? 1 : 0)
-#define WRITE_PIN(IO, v)        ((v) ? WRITE_PIN_SET(IO) : WRITE_PIN_CLR(IO))
+#define WRITE_PIN(IO,V)         ((V) ? WRITE_PIN_SET(IO) : WRITE_PIN_CLR(IO))
 
 /**
  * Magic I/O routines
@@ -69,9 +69,9 @@ bool useable_hardware_PWM(pin_t pin);
 #define _READ(IO)         READ_PIN(IO)
 
 /// Write to a pin
-#define _WRITE_VAR(IO, v) digitalWrite(IO, v)
+#define _WRITE_VAR(IO,V)  digitalWrite(IO,V)
 
-#define _WRITE(IO, v) WRITE_PIN(IO, v)
+#define _WRITE(IO,V)      WRITE_PIN(IO,V)
 
 /// toggle a pin
 #define _TOGGLE(IO)       _WRITE(IO, !READ(IO))
@@ -83,10 +83,10 @@ bool useable_hardware_PWM(pin_t pin);
 #define _SET_OUTPUT(IO)   SET_DIR_OUTPUT(IO)
 
 /// set pin as input with pullup mode
-#define _PULLUP(IO, v) (pinMode(IO, (v!=LOW ? INPUT_PULLUP : INPUT)))
+#define _PULLUP(IO,V)     pinMode(IO, (V) ? INPUT_PULLUP : INPUT)
 
 /// set pin as input with pulldown mode
-#define _PULLDOWN(IO, v) (pinMode(IO, (v!=LOW ? INPUT_PULLDOWN : INPUT)))
+#define _PULLDOWN(IO,V)   pinMode(IO, (V) ? INPUT_PULLDOWN : INPUT)
 
 // hg42: all pins can be input or output (I hope)
 // hg42: undefined pins create compile error (IO, is no pin)
@@ -112,8 +112,8 @@ bool useable_hardware_PWM(pin_t pin);
 #define READ(IO)          _READ(IO)
 
 /// Write to a pin wrapper
-#define WRITE_VAR(IO, v)  _WRITE_VAR(IO, v)
-#define WRITE(IO, v)  _WRITE(IO, v)
+#define WRITE_VAR(IO,V)   _WRITE_VAR(IO,V)
+#define WRITE(IO,V)       _WRITE(IO,V)
 
 /// toggle a pin wrapper
 #define TOGGLE(IO)        _TOGGLE(IO)
@@ -136,6 +136,6 @@ bool useable_hardware_PWM(pin_t pin);
 #define GET_TIMER(IO)     _GET_TIMER(IO)
 
 // Shorthand
-#define OUT_WRITE(IO, v) { SET_OUTPUT(IO); WRITE(IO, v); }
+#define OUT_WRITE(IO,V)   do{ SET_OUTPUT(IO); WRITE(IO,V); }while(0)
 
 #endif // _FASTIO_LPC1768_H

Marlin/src/HAL/HAL_STM32F1/fastio_Stm32f1.h

@@ -34,7 +34,7 @@
 #define READ(IO)              (PIN_MAP[IO].gpio_device->regs->IDR & (1U << PIN_MAP[IO].gpio_bit) ? HIGH : LOW)
 #define WRITE(IO,V)           (PIN_MAP[IO].gpio_device->regs->BSRR = (1U << PIN_MAP[IO].gpio_bit) << (16 * !(bool)V))
 #define TOGGLE(IO)            (PIN_MAP[IO].gpio_device->regs->ODR = PIN_MAP[IO].gpio_device->regs->ODR ^ (1U << PIN_MAP[IO].gpio_bit))
-#define WRITE_VAR(IO,V)       WRITE(io,V)
+#define WRITE_VAR(IO,V)       WRITE(IO,V)
 
 #define _GET_MODE(IO)         gpio_get_mode(PIN_MAP[IO].gpio_device, PIN_MAP[IO].gpio_bit)
 #define _SET_MODE(IO,M)       gpio_set_mode(PIN_MAP[IO].gpio_device, PIN_MAP[IO].gpio_bit, M)

Marlin/src/HAL/HAL_STM32F4/fastio_STM32F4.h

@@ -32,25 +32,26 @@
 #define _BV(b) (1 << (b))
 
 #define READ(IO)                digitalRead(IO)
-#define WRITE(IO, v)          digitalWrite(IO,v)
-#define TOGGLE(IO)            do{ _SET_OUTPUT(IO); digitalWrite(IO,!digitalRead(IO)); }while(0)
-#define WRITE_VAR(IO, v)      digitalWrite(IO,v)
+#define WRITE(IO,V)             digitalWrite(IO,V)
+#define WRITE_VAR(IO,V)         WRITE(IO,V)
 
 #define _GET_MODE(IO)
 #define _SET_MODE(IO,M)         pinMode(IO, M)
 #define _SET_OUTPUT(IO)         pinMode(IO, OUTPUT)                               /*!< Output Push Pull Mode & GPIO_NOPULL   */
 
+#define OUT_WRITE(IO,V)         do{ _SET_OUTPUT(IO); WRITE(IO,V); }while(0)
+
 #define SET_INPUT(IO)           _SET_MODE(IO, INPUT)                              /*!< Input Floating Mode                   */
 #define SET_INPUT_PULLUP(IO)    _SET_MODE(IO, INPUT_PULLUP)                       /*!< Input with Pull-up activation         */
-#define SET_INPUT_PULLDOW(IO) _SET_MODE(IO, INPUT_PULLDOWN)                     /*!< Input with Pull-down activation       */
-#define SET_OUTPUT(IO)        do{ _SET_OUTPUT(IO); WRITE(IO, LOW); }while(0)
+#define SET_INPUT_PULLDOWN(IO)  _SET_MODE(IO, INPUT_PULLDOWN)                     /*!< Input with Pull-down activation       */
+#define SET_OUTPUT(IO)          OUT_WRITE(IO, LOW)
+
+#define TOGGLE(IO)              OUT_WRITE(IO, !READ(IO))
 
 #define GET_INPUT(IO)
 #define GET_OUTPUT(IO)
 #define GET_TIMER(IO)
 
-#define OUT_WRITE(IO, v) { _SET_OUTPUT(IO); WRITE(IO, v); }
-
 #define PORTA 0
 #define PORTB 1
 #define PORTC 2

Marlin/src/HAL/HAL_STM32F7/fastio_STM32F7.h

@@ -32,25 +32,26 @@
 #define _BV(b) (1 << (b))
 
 #define READ(IO)                digitalRead(IO)
-#define WRITE(IO, v)          digitalWrite(IO,v)
-#define TOGGLE(IO)            do{ _SET_OUTPUT(IO); digitalWrite(IO,!digitalRead(IO)); }while(0)
-#define WRITE_VAR(IO, v)      digitalWrite(IO,v)
+#define WRITE(IO,V)             digitalWrite(IO,V)
+#define WRITE_VAR(IO,V)         WRITE(IO,V)
 
 #define _GET_MODE(IO)
 #define _SET_MODE(IO,M)         pinMode(IO, M)
 #define _SET_OUTPUT(IO)         pinMode(IO, OUTPUT)                               /*!< Output Push Pull Mode & GPIO_NOPULL   */
 
+#define OUT_WRITE(IO,V)         do{ _SET_OUTPUT(IO); WRITE(IO,V); }while(0)
+
 #define SET_INPUT(IO)           _SET_MODE(IO, INPUT)                              /*!< Input Floating Mode                   */
 #define SET_INPUT_PULLUP(IO)    _SET_MODE(IO, INPUT_PULLUP)                       /*!< Input with Pull-up activation         */
-#define SET_INPUT_PULLDOW(IO) _SET_MODE(IO, INPUT_PULLDOWN)                     /*!< Input with Pull-down activation       */
-#define SET_OUTPUT(IO)        do{ _SET_OUTPUT(IO); WRITE(IO, LOW); }while(0)
+#define SET_INPUT_PULLDOWN(IO)  _SET_MODE(IO, INPUT_PULLDOWN)                     /*!< Input with Pull-down activation       */
+#define SET_OUTPUT(IO)          OUT_WRITE(IO, LOW)
+
+#define TOGGLE(IO)              OUT_WRITE(IO, !READ(IO))
 
 #define GET_INPUT(IO)
 #define GET_OUTPUT(IO)
 #define GET_TIMER(IO)
 
-#define OUT_WRITE(IO, v) { _SET_OUTPUT(IO); WRITE(IO, v); }
-
 #define PORTA 0
 #define PORTB 1
 #define PORTC 2